Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: kubernetes executor overwrites self.envvars as an attribute #27

Closed
jjjermiah opened this issue Oct 7, 2024 · 0 comments
Closed

bug: kubernetes executor overwrites self.envvars as an attribute #27

jjjermiah opened this issue Oct 7, 2024 · 0 comments

Comments

@jjjermiah
Copy link
Collaborator

snakemake_interface_executor_plugin::executors::real.envars() declared as a method
but then is overwritten as a class attribute

which results in

  File "path/to/snakemake_interface_executor_plugins/executors/real.py", line 160, in format_job_exec
    self.get_envvar_declarations(),
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "path/to/snakemake_interface_executor_plugins/executors/real.py", line 129, in get_envvar_declarations
    envars = self.envvars()
             ^^^^^^^^^^^^^^

TypeError: 'dict' object is not callable
jjjermiah added a commit to jjjermiah/snakemake-executor-plugin-kubernetes that referenced this issue Oct 7, 2024
@jjjermiah
fix: snakemake#27 attribute overwriting envvars method in RealExecutor
6ea1b87
@github-actions github-actions bot mentioned this issue Oct 8, 2024
Merged
jjjermiah pushed a commit that referenced this issue Oct 8, 2024
@github-actions
chore(main): release 0.2.2 (#29)
c15750a 
🤖 I have created a release *beep* *boop*
---


##
[0.2.2](v0.2.1...v0.2.2)
(2024-10-08)


### Bug Fixes

*
[#27](#27)
attribute overwriting envvars method in `RealExecutor`
([#28](#28))
([d6c0bd5](d6c0bd5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jjjermiah