Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was wondering if this is a good idea or not: based on the
resources
parameter in snakemake rules, then build-Xmx
parameter automatically for any java tool that allow this kind of parameters.Here, the conda wrapper of almost any picard subcommands handles
-Xm*
, and-D*
options, soXmx
is handled.If you agree with this, I am willing to do the same in Picard, SnpSift, SnpEff, GATK and Trinity (max_memory). If you see any other tool that would need such changes, please tell me and I'll be happy to make the changes.
Thanks in advance for your reviews.
PS: The modifications in
generate_docs.py
come from a PR i did this morning. I don't know how to hide it since it has been already accepted.