Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java (picard) -Xmx parameter #189

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Conversation

tdayris
Copy link
Contributor

@tdayris tdayris commented Sep 21, 2020

Hi,

I was wondering if this is a good idea or not: based on the resources parameter in snakemake rules, then build -Xmx parameter automatically for any java tool that allow this kind of parameters.

Here, the conda wrapper of almost any picard subcommands handles -Xm*, and -D* options, so Xmx is handled.

If you agree with this, I am willing to do the same in Picard, SnpSift, SnpEff, GATK and Trinity (max_memory). If you see any other tool that would need such changes, please tell me and I'll be happy to make the changes.

Thanks in advance for your reviews.

PS: The modifications in generate_docs.py come from a PR i did this morning. I don't know how to hide it since it has been already accepted.

Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome idea, I would very much welcome it!

@johanneskoester johanneskoester merged commit b40ba24 into snakemake:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants