-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deeptools multibigwig summary #3135
feat: Deeptools multibigwig summary #3135
Conversation
* perf: update bio/bcftools/index/environment.yaml. * perf: update bio/bcftools/index/environment.yaml. * perf: update bio/bcftools/index/environment.yaml.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
* Add autobump action * fix paths * dbg * dbg branch * add checkout * dbg * trigger rerun * entity regex and add label * dbg * Update autobump.yml * Update autobump.yml
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
WalkthroughThe changes introduce new configuration files for the DeepTools project, specifically for the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Outside diff range, codebase verification and nitpick comments (2)
bio/deeptools/multibigwigsummary/test/Snakefile (2)
1-14
: Consider using a more descriptive log file name.The log file name
bins.logs
is too generic. Consider using a more descriptive name to better understand the context of the logs.Example:
- log: - "bins.logs" + log: + "logs/test_deeptools_multibwsummary_bins.log"
16-30
: Consider using a more descriptive log file name.The log file name
bins.logs
is too generic. Consider using a more descriptive name to better understand the context of the logs.Example:
- log: - "bins.logs" + log: + "logs/test_deeptools_multibwsummary_bed.log"
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- bio/deeptools/multibigwigsummary/environment.linux-64.pin.txt (1 hunks)
- bio/deeptools/multibigwigsummary/environment.yaml (1 hunks)
- bio/deeptools/multibigwigsummary/meta.yaml (1 hunks)
- bio/deeptools/multibigwigsummary/test/Snakefile (1 hunks)
- bio/deeptools/multibigwigsummary/test/blacklist.bed (1 hunks)
- bio/deeptools/multibigwigsummary/test/intervals.bed (1 hunks)
- bio/deeptools/multibigwigsummary/wrapper.py (1 hunks)
- test.py (1 hunks)
Files skipped from review due to trivial changes (3)
- bio/deeptools/multibigwigsummary/environment.yaml
- bio/deeptools/multibigwigsummary/test/blacklist.bed
- bio/deeptools/multibigwigsummary/test/intervals.bed
Additional context used
Path-based instructions (2)
bio/deeptools/multibigwigsummary/wrapper.py (2)
Pattern
**/*.py
: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of theself
argument of methods.
Do not suggest type annotation of thecls
argument of classmethods.
Do not suggest return type annotation if a function or method does not contain areturn
statement.
Pattern
**/wrapper.py
: Do not complain about use of undefined variable calledsnakemake
.test.py (1)
Pattern
**/*.py
: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of theself
argument of methods.
Do not suggest type annotation of thecls
argument of classmethods.
Do not suggest return type annotation if a function or method does not contain areturn
statement.
Ruff
bio/deeptools/multibigwigsummary/wrapper.py
12-12: Undefined name
snakemake
(F821)
13-13: Undefined name
snakemake
(F821)
15-15: Undefined name
snakemake
(F821)
19-19: Undefined name
snakemake
(F821)
23-23: Undefined name
snakemake
(F821)
Additional comments not posted (18)
bio/deeptools/multibigwigsummary/meta.yaml (8)
1-1
: LGTM!The name is correctly defined.
The code changes are approved.
2-2
: LGTM!The URL is correctly defined.
The code changes are approved.
3-4
: LGTM!The description is correctly defined.
The code changes are approved.
5-6
: LGTM!The author is correctly defined.
The code changes are approved.
7-10
: LGTM!The input section is correctly defined.
The code changes are approved.
11-13
: LGTM!The output section is correctly defined.
The code changes are approved.
14-15
: LGTM!The params section is correctly defined.
The code changes are approved.
16-17
: LGTM!The notes section is correctly defined.
The code changes are approved.
bio/deeptools/multibigwigsummary/wrapper.py (7)
1-6
: LGTM!The metadata section is correctly defined.
The code changes are approved.
9-9
: LGTM!The import statement is correctly defined.
The code changes are approved.
11-13
: LGTM!The optional parameters are correctly defined.
The code changes are approved.
Tools
Ruff
12-12: Undefined name
snakemake
(F821)
13-13: Undefined name
snakemake
(F821)
15-17
: LGTM!The
blacklist
parameter is correctly defined.The code changes are approved.
Tools
Ruff
15-15: Undefined name
snakemake
(F821)
19-21
: LGTM!The
out_raw_counts
parameter is correctly defined.The code changes are approved.
Tools
Ruff
19-19: Undefined name
snakemake
(F821)
23-27
: LGTM!The
bed
parameter is correctly defined.The code changes are approved.
Tools
Ruff
23-23: Undefined name
snakemake
(F821)
30-36
: LGTM!The shell command is correctly defined.
The code changes are approved.
bio/deeptools/multibigwigsummary/environment.linux-64.pin.txt (3)
1-3
: LGTM!The header section provides clear instructions for creating a conda environment using the file.
The code changes are approved.
4-4
: LGTM!The
@EXPLICIT
directive is correctly used to ensure reproducibility.The code changes are approved.
5-112
: LGTM!The list of package URLs is correctly specified to ensure the environment is created with the exact versions required.
The code changes are approved.
🤖 I have created a release \*beep\* \*boop\* --- ## [4.3.0](https://www.github.com/snakemake/snakemake-wrappers/compare/v4.2.0...v4.3.0) (2024-08-28) ### Features * add support for multiple input file subcommands in seqkit wrapper (subcommands "common" and "concat") ([#3142](https://www.github.com/snakemake/snakemake-wrappers/issues/3142)) ([3b5391f](https://www.github.com/snakemake/snakemake-wrappers/commit/3b5391f619b38334829c06b8bd0526a16e19c732)) * Deeptools multibigwig summary ([#3135](https://www.github.com/snakemake/snakemake-wrappers/issues/3135)) ([df7e2bf](https://www.github.com/snakemake/snakemake-wrappers/commit/df7e2bffdd61690e56380bb1b49ca663e58a477c)) * Deeptools plot correlation ([#3137](https://www.github.com/snakemake/snakemake-wrappers/issues/3137)) ([a965bd6](https://www.github.com/snakemake/snakemake-wrappers/commit/a965bd62f13bb62722daf08201a00b1f26bef38d)) * Deeptools plot pca ([#3138](https://www.github.com/snakemake/snakemake-wrappers/issues/3138)) ([0d9862b](https://www.github.com/snakemake/snakemake-wrappers/commit/0d9862b0f91e74bb90993eb7ecb938dec80d779b)) * Rseqc bamstat ([#3139](https://www.github.com/snakemake/snakemake-wrappers/issues/3139)) ([b4267e6](https://www.github.com/snakemake/snakemake-wrappers/commit/b4267e6a0244071a96efc8a91fd6ba982a738cb5)) * Rseqc inner distance ([#3140](https://www.github.com/snakemake/snakemake-wrappers/issues/3140)) ([8ca10f3](https://www.github.com/snakemake/snakemake-wrappers/commit/8ca10f3949ca6fb1ed9f9d046c89ca10a7c32c8c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
QC
snakemake-wrappers
.While the contributions guidelines are more extensive, please particularly ensure that:
test.py
was updated to call any added or updated example rules in aSnakefile
input:
andoutput:
file paths in the rules can be chosen arbitrarilyinput:
oroutput:
)tempfile.gettempdir()
points tometa.yaml
contains a link to the documentation of the respective tool or command underurl:
Summary by CodeRabbit
New Features
environment.linux-64.pin.txt
,environment.yaml
) to streamline installation for DeepTools.meta.yaml
file providing essential metadata and configuration for thedeeptools multi bigwig summary
tool.wrapper.py
script to facilitate integration of themultiBigwigSummary
command within Snakemake workflows.multibigwigsummary
command to ensure functionality with different inputs.Documentation
Tests
deeptools multibigwigsummary
functionality to improve coverage and reliability.