Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deeptools multibigwig summary #3135

Merged
merged 55 commits into from
Aug 26, 2024

Conversation

tdayris
Copy link
Contributor

@tdayris tdayris commented Aug 26, 2024

QC

While the contributions guidelines are more extensive, please particularly ensure that:

  • test.py was updated to call any added or updated example rules in a Snakefile
  • input: and output: file paths in the rules can be chosen arbitrarily
  • wherever possible, command line arguments are inferred and set automatically (e.g. based on file extensions in input: or output:)
  • temporary files are either written to a unique hidden folder in the working directory, or (better) stored where the Python function tempfile.gettempdir() points to
  • the meta.yaml contains a link to the documentation of the respective tool or command under url:
  • conda environments use a minimal amount of channels and packages, in recommended ordering

Summary by CodeRabbit

  • New Features

    • Introduced new files for setting up Conda environments (environment.linux-64.pin.txt, environment.yaml) to streamline installation for DeepTools.
    • Added a meta.yaml file providing essential metadata and configuration for the deeptools multi bigwig summary tool.
    • Created a wrapper.py script to facilitate integration of the multiBigwigSummary command within Snakemake workflows.
    • Added test cases for the multibigwigsummary command to ensure functionality with different inputs.
  • Documentation

    • Enhanced user guidance with new configuration files and structured metadata for better usability in genomic analyses.
  • Tests

    • Included new tests for the deeptools multibigwigsummary functionality to improve coverage and reliability.

tdayris and others added 30 commits September 21, 2020 09:16
* perf: update bio/bcftools/index/environment.yaml.

* perf: update bio/bcftools/index/environment.yaml.

* perf: update bio/bcftools/index/environment.yaml.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
* Add autobump action

* fix paths

* dbg

* dbg branch

* add checkout

* dbg

* trigger rerun

* entity regex and add label

* dbg

* Update autobump.yml

* Update autobump.yml
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Co-authored-by: snakedeploy-bot[bot] <115615832+snakedeploy-bot[bot]@users.noreply.github.com>
Copy link
Contributor

coderabbitai bot commented Aug 26, 2024

Walkthrough

The changes introduce new configuration files for the DeepTools project, specifically for the multiBigwigSummary tool. These include an environment specification file for Conda, a metadata file outlining the tool's functionality, and testing scripts for workflow integration. Additional test data files are provided to facilitate genomic interval analysis. The modifications enhance the project's structure and usability for bioinformatics applications.

Changes

Files Change Summary
bio/deeptools/multibigwigsummary/environment.linux-64.pin.txt New file created with explicit package dependencies for Conda environment setup.
bio/deeptools/multibigwigsummary/environment.yaml New file defining environment configuration with channels and dependencies for DeepTools.
bio/deeptools/multibigwigsummary/meta.yaml New metadata file providing tool description, inputs, outputs, and parameters for the summary.
bio/deeptools/multibigwigsummary/test/Snakefile New file with rules for Snakemake workflow to process bigwig files.
bio/deeptools/multibigwigsummary/test/blacklist.bed New file containing a dataset for regions to exclude in analyses.
bio/deeptools/multibigwigsummary/test/intervals.bed New file with genomic interval definitions for analysis.
bio/deeptools/multibigwigsummary/wrapper.py New wrapper script for integrating multiBigwigSummary command into Snakemake workflows.
test.py New test function added to execute the multibigwigsummary command with different parameters.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range, codebase verification and nitpick comments (2)
bio/deeptools/multibigwigsummary/test/Snakefile (2)

1-14: Consider using a more descriptive log file name.

The log file name bins.logs is too generic. Consider using a more descriptive name to better understand the context of the logs.

Example:

-    log:
-        "bins.logs"
+    log:
+        "logs/test_deeptools_multibwsummary_bins.log"

16-30: Consider using a more descriptive log file name.

The log file name bins.logs is too generic. Consider using a more descriptive name to better understand the context of the logs.

Example:

-    log:
-        "bins.logs"
+    log:
+        "logs/test_deeptools_multibwsummary_bed.log"
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a248fa9 and 1c410c9.

Files selected for processing (8)
  • bio/deeptools/multibigwigsummary/environment.linux-64.pin.txt (1 hunks)
  • bio/deeptools/multibigwigsummary/environment.yaml (1 hunks)
  • bio/deeptools/multibigwigsummary/meta.yaml (1 hunks)
  • bio/deeptools/multibigwigsummary/test/Snakefile (1 hunks)
  • bio/deeptools/multibigwigsummary/test/blacklist.bed (1 hunks)
  • bio/deeptools/multibigwigsummary/test/intervals.bed (1 hunks)
  • bio/deeptools/multibigwigsummary/wrapper.py (1 hunks)
  • test.py (1 hunks)
Files skipped from review due to trivial changes (3)
  • bio/deeptools/multibigwigsummary/environment.yaml
  • bio/deeptools/multibigwigsummary/test/blacklist.bed
  • bio/deeptools/multibigwigsummary/test/intervals.bed
Additional context used
Path-based instructions (2)
bio/deeptools/multibigwigsummary/wrapper.py (2)

Pattern **/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of the self argument of methods.
Do not suggest type annotation of the cls argument of classmethods.
Do not suggest return type annotation if a function or method does not contain a return statement.


Pattern **/wrapper.py: Do not complain about use of undefined variable called snakemake.

test.py (1)

Pattern **/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of the self argument of methods.
Do not suggest type annotation of the cls argument of classmethods.
Do not suggest return type annotation if a function or method does not contain a return statement.

Ruff
bio/deeptools/multibigwigsummary/wrapper.py

12-12: Undefined name snakemake

(F821)


13-13: Undefined name snakemake

(F821)


15-15: Undefined name snakemake

(F821)


19-19: Undefined name snakemake

(F821)


23-23: Undefined name snakemake

(F821)

Additional comments not posted (18)
bio/deeptools/multibigwigsummary/meta.yaml (8)

1-1: LGTM!

The name is correctly defined.

The code changes are approved.


2-2: LGTM!

The URL is correctly defined.

The code changes are approved.


3-4: LGTM!

The description is correctly defined.

The code changes are approved.


5-6: LGTM!

The author is correctly defined.

The code changes are approved.


7-10: LGTM!

The input section is correctly defined.

The code changes are approved.


11-13: LGTM!

The output section is correctly defined.

The code changes are approved.


14-15: LGTM!

The params section is correctly defined.

The code changes are approved.


16-17: LGTM!

The notes section is correctly defined.

The code changes are approved.

bio/deeptools/multibigwigsummary/wrapper.py (7)

1-6: LGTM!

The metadata section is correctly defined.

The code changes are approved.


9-9: LGTM!

The import statement is correctly defined.

The code changes are approved.


11-13: LGTM!

The optional parameters are correctly defined.

The code changes are approved.

Tools
Ruff

12-12: Undefined name snakemake

(F821)


13-13: Undefined name snakemake

(F821)


15-17: LGTM!

The blacklist parameter is correctly defined.

The code changes are approved.

Tools
Ruff

15-15: Undefined name snakemake

(F821)


19-21: LGTM!

The out_raw_counts parameter is correctly defined.

The code changes are approved.

Tools
Ruff

19-19: Undefined name snakemake

(F821)


23-27: LGTM!

The bed parameter is correctly defined.

The code changes are approved.

Tools
Ruff

23-23: Undefined name snakemake

(F821)


30-36: LGTM!

The shell command is correctly defined.

The code changes are approved.

bio/deeptools/multibigwigsummary/environment.linux-64.pin.txt (3)

1-3: LGTM!

The header section provides clear instructions for creating a conda environment using the file.

The code changes are approved.


4-4: LGTM!

The @EXPLICIT directive is correctly used to ensure reproducibility.

The code changes are approved.


5-112: LGTM!

The list of package URLs is correctly specified to ensure the environment is created with the exact versions required.

The code changes are approved.

test.py Show resolved Hide resolved
@fgvieira fgvieira merged commit df7e2bf into snakemake:master Aug 26, 2024
7 checks passed
dlaehnemann pushed a commit that referenced this pull request Aug 29, 2024
🤖 I have created a release \*beep\* \*boop\*
---
##
[4.3.0](https://www.github.com/snakemake/snakemake-wrappers/compare/v4.2.0...v4.3.0)
(2024-08-28)


### Features

* add support for multiple input file subcommands in seqkit wrapper
(subcommands "common" and "concat")
([#3142](https://www.github.com/snakemake/snakemake-wrappers/issues/3142))
([3b5391f](https://www.github.com/snakemake/snakemake-wrappers/commit/3b5391f619b38334829c06b8bd0526a16e19c732))
* Deeptools multibigwig summary
([#3135](https://www.github.com/snakemake/snakemake-wrappers/issues/3135))
([df7e2bf](https://www.github.com/snakemake/snakemake-wrappers/commit/df7e2bffdd61690e56380bb1b49ca663e58a477c))
* Deeptools plot correlation
([#3137](https://www.github.com/snakemake/snakemake-wrappers/issues/3137))
([a965bd6](https://www.github.com/snakemake/snakemake-wrappers/commit/a965bd62f13bb62722daf08201a00b1f26bef38d))
* Deeptools plot pca
([#3138](https://www.github.com/snakemake/snakemake-wrappers/issues/3138))
([0d9862b](https://www.github.com/snakemake/snakemake-wrappers/commit/0d9862b0f91e74bb90993eb7ecb938dec80d779b))
* Rseqc bamstat
([#3139](https://www.github.com/snakemake/snakemake-wrappers/issues/3139))
([b4267e6](https://www.github.com/snakemake/snakemake-wrappers/commit/b4267e6a0244071a96efc8a91fd6ba982a738cb5))
* Rseqc inner distance
([#3140](https://www.github.com/snakemake/snakemake-wrappers/issues/3140))
([8ca10f3](https://www.github.com/snakemake/snakemake-wrappers/commit/8ca10f3949ca6fb1ed9f9d046c89ca10a7c32c8c))
---


This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Sep 24, 2024
7 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 13, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants