Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pip-installable #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Make pip-installable #3

wants to merge 6 commits into from

Conversation

cthoyt
Copy link

@cthoyt cthoyt commented Dec 23, 2020

This PR does the following:

  1. Reorganizes code into the src/ layout. I've given the name of the package kgreasoning, but you can change this to whatever you'd like
  2. Switch imports to use "absolute" imports for dataloader.py, util.py and models.py
  3. Adds setup configuration with setup.cfg and setup.py and add installation documentation to the README
  4. Reorganize the code in main.py so it can be installed as a vanity CLI script using python entrypoints. The README and example script are updated accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cthoyt