Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setStyle fails if newElement.parentNode is a document fragment #2391

Closed
Mobe91 opened this issue Feb 12, 2020 · 1 comment · Fixed by #2392
Closed

setStyle fails if newElement.parentNode is a document fragment #2391

Mobe91 opened this issue Feb 12, 2020 · 1 comment · Fixed by #2392

Comments

@Mobe91
Copy link
Contributor

Mobe91 commented Feb 12, 2020 •
edited
Loading

With version 1.13.12 and Bootstrap 3, setStyle fails if newElement.parentNode is a document fragment because classList is undefined in this case. This used to not be a problem with version 1.13.5.

Also, the call to buildData() in refresh() should come before render() like it is done in init().
Mobe91 added a commit to ordami/bootstrap-select that referenced this issue Feb 12, 2020
@Mobe91
[snapappointments#2391] fix error in setStyle for Bootstrap 3 when pa…
79f075b 
…rentNode is a document fragment
Mobe91 added a commit to ordami/bootstrap-select that referenced this issue Feb 12, 2020
@Mobe91
[snapappointments#2391] invoke buildData() before render() in refresh…
78b4bbe 
…() to align order with init()
@Mobe91 Mobe91 mentioned this issue Feb 12, 2020
Merged
caseyjhol pushed a commit that referenced this issue Apr 21, 2020
@Mobe91
Bug/2391 set style with document fragment parent (#2392)
158704d 
* [#2391] fix error in setStyle for Bootstrap 3 when parentNode is a document fragment

* [#2391] invoke buildData() before render() in refresh() to align order with init()
@caseyjhol caseyjhol reopened this Apr 21, 2020
@caseyjhol
Copy link
Member

Released in v1.13.16!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug/2391 set style with document fragment parent ordami/bootstrap-select
2 participants
@caseyjhol @Mobe91