-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
liHeight does not consider custom option content when computing li height #2393
Comments
Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case (you can use our preconfigured Plunker), and report back with:
If you're not using the latest version of bootstrap-select, please try that as well. |
Here is a reproducer: https://plnkr.co/edit/MAlf9YRQoz948SPM Bootstrap version: 4.1.0 I have changed the first select to use custom html option content + virtual scroll. Just scroll to the very end of the option list and you will see blank content caused by wrong li height calculation. The reproducer is fixed by applying the changes from this PR. |
Released in v1.13.16! |
Adding in a disabled first option and setting data-hide-disabled="false" breaks this. |
Currently, liHeight creates an artificial
li
element with static content to compute itsoffsetHeight
. This height is later used for virtual scrolling.However, when a user supplies custom content via the
data-content
attribute, the current approach does not yield the correct li height.The text was updated successfully, but these errors were encountered: