add SASS version #1227
Merged
add SASS version #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please get this merged asap? I need SASS as well. Thanks! |
|
+1 for me |
|
@bsorem-sugarcrm I cant test your commit. Can I trust in your PR? |
|
@silviomereto I hope so! I compiled it to CSS using SASS and manually compared that to the LESS-generated CSS. |
|
Ok, it is already accepted. Thanks |
|
Dear @silviomoreto , even if it has problems, we - SASS users - will send additional PRs to fix it up :D Thanks for the merge. Please make sure you have a release with this inside, so that we could use it with Bower. @bsorem-sugarcrm : at least you verified it's integrity by converting to CSS right (with Compass or some JS/Gulp tool)? |
|
done 4d47d75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers #1199