Fixes edge case where default values are not respected when initialising the plugin #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JS rather than markup. The plugin did not detect the default selected value
caseyjhol
added a commit
that referenced
this pull request
Aug 4, 2016
avantika-gupta-jtg
pushed a commit
to JoshLabs/bootstrap-select
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue when using a title and a default selected option set with JS rather than markup. The plugin did not detect the default selected value.
It was using
attrbut that only detects the initial default value set via markup attributes. If the current selected value had been changed by JS prior to initialising the plugin (bound to backbone model for example) then the value was not detected.Needed to check for
propas well, as this checks the current value as well.