Start counting selected options at 1 #2403
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #2367 : currently if set
selectedTextFormat
tocount
orcount > 0
, when the user selects one option, the text displayed can be determined usingcountSelectedText
unless the user happens to select only one option, and then that one option is displayed. That can look very inconsistent, especially if the<select>
has a limited width and the selected option is longer.The change here just fixes the
selectedCount
threshold at which thecountSelectedText
function comes into play (from 2 to 1). Test cases are included. I don't think the documentation needs to be updated, since that's already accurate:This could be considered a breaking change to anyone who's expecting/relying on the previous behavior, but it's easy to get back the previous behavior by setting
selectedTextFormat
tocount > 1