Fixes two TypeError exceptions when up/down arrow pressed
#2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2021 10:30
when using live search, if a user enters a value that does not return any results and then presses the up/down arrows, this error occurs. this commit fixes that error.
when using live search, if a user enters a value that does not return any results and then presses the up/down arrows, this error occurs. this commit fixes that error.
|
This fix should work in v1.14.0 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like issue #2035 is happening again in the latest v1.13 release. When using live search, if a user enters a query that has no matches and then presses the up or down arrows, two different
TypeErrorexceptions can occur. This PR fixes both exceptions.For reference, here are the steps to reproduce the issue, copied from the original issue:
Browser: All
OS environment: All
Steps to reproduce: