[#2667]fix the bug of the data-size when the first option style has 'display: none' #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js/bootstrap-select.js
Outdated
| @@ -1920,7 +1920,8 @@ | |||
| if (this.selectpicker.current.data.length) { | |||
| for (var i = 0; i < this.selectpicker.current.data.length; i++) { | |||
| var data = this.selectpicker.current.data[i]; | |||
| if (data.type === 'option') { | |||
| var a = data.element.firstChild; | |||
There was a problem hiding this comment.
a is a poor variable name choice
megumiimai
changed the title
megumiimai
changed the title
NicolasCARPi
requested changes
Mar 1, 2022
There was a problem hiding this comment.
Thank you for your contribution. This change would be a good opportunity to add a test case in the tests folder (even if we don't currently test automatically for things yet). Basically an example showing the problem, and showing that with this PR the problem goes away!
|
thank you for reviewing. I added a test (febdfea) and pasted the capture. How about that? problem
fixed
|
NicolasCARPi
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #2667