Unify async-delegate continuations and fix autofill-to-modal data race #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firehed
added a commit
that referenced
this pull request
Jul 28, 2024
As noted in #29, the initial design of the autofill interactions used a delegate-based system, rather than async/await like the modal APIs. This was based on an incorrect assumption (carried over from web, where it may also be flawed) on how promises resolve. Upon further experimentation, it seems perfectly fine and non-problematic to have a promise that might take minutes to resolve and not have it block other interactions. This (breaking) change adjusts the autofill API to also use async/await instead of delegates. Client code is a lot more straightforward, and the internals become more reliable since a bunch of conditional paths are eliminated. In the same vein, I've also added a new `.unsupportedOnPlatform` error code so that clients can have fewer availability checks, part of #30. The API as a whole is still `#if`'d to iOS+visionOS, but that will get lifted eventually in a separate PR (see #16).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of maintaining a bunch of internal state and logic to figure out whether a registration, modal authentication, or autofill authentication is currently being processed, this collapses the logic significantly to have a single continuation that manages both modal paths. Now at the start of all public calls,
reset()is triggered which should reliably reset (and clear out) all of the continuation stuff andAutofill is a little finicky still, but upon further testing on different branches, it looks like some of the assumptions made in the initial design (with a delegate class for clients) were incorrect and it should be possible to move that to async as well. That'll be addressed separately; for the moment the existing API will continue to work,
Fixes #25