Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: include project provided assumes in snapd.yaml #4152

Merged
merged 1 commit into from
May 18, 2023

Conversation

sergiusens
Copy link
Collaborator

@sergiusens sergiusens commented May 18, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

craft-1734

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens changed the base branch from main to hotfix/7.3 May 18, 2023 13:43
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Merging #4152 (deee09e) into hotfix/7.3 (bef32e2) will increase coverage by 0.24%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff               @@
##           hotfix/7.3    #4152      +/-   ##
==============================================
+ Coverage       94.56%   94.80%   +0.24%     
==============================================
  Files             652      648       -4     
  Lines           52524    54294    +1770     
==============================================
+ Hits            49668    51475    +1807     
+ Misses           2856     2819      -37     
Impacted Files Coverage Δ
snapcraft/meta/snap_yaml.py 96.62% <100.00%> (+0.22%) ⬆️
tests/unit/meta/test_snap_yaml.py 100.00% <100.00%> (ø)

... and 68 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens merged commit 36dca72 into hotfix/7.3 May 18, 2023
@sergiusens sergiusens deleted the hotfix/7.3-assumes branch May 18, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants