Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove arch_triplet from unit test #4160

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented May 19, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Minor fix for unit tests.

Two PRs (1 and 2) touched the same unit test file. One removed all references to arch_triplet and the other added 2 more tests with arch_triplet still present.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #4160 (0ceea7a) into main (e52221b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #4160      +/-   ##
==========================================
+ Coverage   94.80%   94.85%   +0.04%     
==========================================
  Files         648      648              
  Lines       54294    54353      +59     
==========================================
+ Hits        51475    51554      +79     
+ Misses       2819     2799      -20     
Impacted Files Coverage Δ
snapcraft/elf/elf_utils.py 95.38% <100.00%> (+0.07%) ⬆️
snapcraft/meta/snap_yaml.py 96.63% <100.00%> (+0.01%) ⬆️
snapcraft/parts/lifecycle.py 92.90% <100.00%> (+4.19%) ⬆️
snapcraft/projects.py 96.12% <100.00%> (+0.05%) ⬆️
snapcraft/utils.py 91.57% <100.00%> (+0.09%) ⬆️
tests/unit/elf/test_elf_utils.py 100.00% <100.00%> (ø)
tests/unit/linters/test_classic_linter.py 100.00% <100.00%> (ø)
tests/unit/linters/test_library_linter.py 100.00% <100.00%> (ø)
tests/unit/linters/test_linters.py 100.00% <100.00%> (ø)
tests/unit/meta/test_snap_yaml.py 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lengau lengau mentioned this pull request May 19, 2023
4 tasks
@cmatsuoka cmatsuoka merged commit 0594429 into main May 23, 2023
@cmatsuoka cmatsuoka deleted the snap-yaml-test-fix branch May 23, 2023 13:00
cmatsuoka pushed a commit to cmatsuoka/snapcraft that referenced this pull request May 23, 2023
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
cmatsuoka pushed a commit to cmatsuoka/snapcraft that referenced this pull request May 23, 2023
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
sergiusens pushed a commit that referenced this pull request May 23, 2023
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants