Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the build process for v6.47.0+ #266

Merged
merged 1 commit into from
Feb 9, 2024
Merged

fix: correct the build process for v6.47.0+ #266

merged 1 commit into from
Feb 9, 2024

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented Feb 9, 2024

This makes a couple of changes to address an issue with recent versions:

  • Use the same version of NPM and Yarn as the upstream CI
  • Stop patching the package.json to build to directory, use new flags

@jnsgruk jnsgruk mentioned this pull request Feb 9, 2024
@jnsgruk jnsgruk linked an issue Feb 9, 2024 that may be closed by this pull request
This makes a couple of changes to address an issue with
recent versions:

- Use the same version of NPM and Yarn as the upstream CI
- Stop patching the package.json to build to directory, use new flags
@popey
Copy link
Contributor

popey commented Feb 9, 2024

Tested on my local machine, building from this PR in lxd. Installed 6.47.0 and it worked fine.

Copy link
Contributor

@popey popey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnsgruk jnsgruk merged commit 325c066 into snapcrafters:candidate Feb 9, 2024
1 check passed
Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jnsgruk jnsgruk deleted the fix-build branch July 3, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Failing to start
3 participants