Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/GitHub workflows #24

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Improve/GitHub workflows #24

merged 3 commits into from
Dec 4, 2023

Conversation

hoptical
Copy link
Collaborator

@hoptical hoptical commented Dec 4, 2023

This PR includes the following changes:

  1. Separates steps in the build workflow for a better readibilty
  2. Updates helm chart to support the new version

Summary by CodeRabbit

  • Chores

    • Updated the continuous integration workflow to enhance the build process.
  • New Features

    • Introduced a new job in the CI pipeline to support advanced build operations.

@hoptical hoptical added the enhancement New feature or request label Dec 4, 2023
@hoptical hoptical requested a review from therealak12 December 4, 2023 10:52
@hoptical hoptical self-assigned this Dec 4, 2023
Copy link
Contributor

coderabbitai bot commented Dec 4, 2023

Walkthrough

The GitHub Actions workflow has been updated with a job renaming and an addition. The docker job has been renamed to build-docker, and a new job called build-push-bundle has been introduced. This new job is set up to run on ubuntu-latest and includes steps for installing the operator-sdk.

Changes

File Path Change Summary
.github/workflows/build.yaml Renamed job from docker to build-docker; Added build-push-bundle job with operator-sdk installation

🐇✨
In the realm of code, where actions flow,
A rabbit hopped, making CI glow.
Renamed a job with a flick of its ear,
Added a bundle, with cheer, never fear! 🚀🎉
🐇✨


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@hoptical hoptical added the helm chart Helm chart is updated label Dec 4, 2023
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 2aac745 and ab6b361.
Files ignored due to filter (11)
  • config/manager/kustomization.yaml
  • deploy/charts/s3-operator/Chart.yaml
  • deploy/charts/s3-operator/templates/clusterresourcequota-updater-binding-rbac.yaml
  • deploy/charts/s3-operator/templates/clusterresourcequota-updater-rbac.yaml
  • deploy/charts/s3-operator/templates/manager-rbac.yaml
  • deploy/charts/s3-operator/templates/resourcequota-status-updater-binding-rbac.yaml
  • deploy/charts/s3-operator/templates/resourcequota-status-updater-rbac.yaml
  • deploy/charts/s3-operator/templates/s3bucket-crd.yaml
  • deploy/charts/s3-operator/templates/s3user-crd.yaml
  • deploy/charts/s3-operator/templates/s3userclaim-crd.yaml
  • deploy/charts/s3-operator/templates/validating-webhook-configuration.yaml
Files selected for processing (1)
  • .github/workflows/build.yaml (2 hunks)
Additional comments: 3
.github/workflows/build.yaml (3)
  • 9-11: The job renaming from docker to build-docker is consistent with the PR objectives and improves the readability of the workflow.

  • 36-42: The addition of the build-push-bundle job with steps to install operator-sdk aligns with the PR objectives to support new Kubernetes Operator functionality.

  • 36-42: Verify that the build-push-bundle job includes all necessary steps for building and pushing the bundle, as the snippet provided seems truncated.

.github/workflows/build.yaml Outdated Show resolved Hide resolved
@hoptical
Copy link
Collaborator Author

hoptical commented Dec 4, 2023

@therealak12 What do you say about moving helm chart directory from deploy/charts/s3-operator to charts?

@hoptical hoptical merged commit b71aeb3 into main Dec 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm chart Helm chart is updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants