-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve/GitHub workflows #24
Conversation
WalkthroughThe GitHub Actions workflow has been updated with a job renaming and an addition. The Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to filter (11)
- config/manager/kustomization.yaml
- deploy/charts/s3-operator/Chart.yaml
- deploy/charts/s3-operator/templates/clusterresourcequota-updater-binding-rbac.yaml
- deploy/charts/s3-operator/templates/clusterresourcequota-updater-rbac.yaml
- deploy/charts/s3-operator/templates/manager-rbac.yaml
- deploy/charts/s3-operator/templates/resourcequota-status-updater-binding-rbac.yaml
- deploy/charts/s3-operator/templates/resourcequota-status-updater-rbac.yaml
- deploy/charts/s3-operator/templates/s3bucket-crd.yaml
- deploy/charts/s3-operator/templates/s3user-crd.yaml
- deploy/charts/s3-operator/templates/s3userclaim-crd.yaml
- deploy/charts/s3-operator/templates/validating-webhook-configuration.yaml
Files selected for processing (1)
- .github/workflows/build.yaml (2 hunks)
Additional comments: 3
.github/workflows/build.yaml (3)
9-11: The job renaming from
docker
tobuild-docker
is consistent with the PR objectives and improves the readability of the workflow.36-42: The addition of the
build-push-bundle
job with steps to installoperator-sdk
aligns with the PR objectives to support new Kubernetes Operator functionality.36-42: Verify that the
build-push-bundle
job includes all necessary steps for building and pushing the bundle, as the snippet provided seems truncated.
@therealak12 What do you say about moving helm chart directory from |
This PR includes the following changes:
Summary by CodeRabbit
Chores
New Features