-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve/GitHub workflows2 #26
Conversation
WalkthroughThe GitHub workflow has been updated to not only build container images but also manage Helm chart operations and create GitHub releases. This expansion streamlines the release process, integrating additional steps into the CI/CD pipeline. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (21)
- charts/s3-operator/Chart.yaml
- charts/s3-operator/templates/clusterresourcequota-updater-binding-rbac.yaml
- charts/s3-operator/templates/clusterresourcequota-updater-rbac.yaml
- charts/s3-operator/templates/controller-manager-config.yaml
- charts/s3-operator/templates/deployment.yaml
- charts/s3-operator/templates/leader-election-rbac.yaml
- charts/s3-operator/templates/manager-rbac.yaml
- charts/s3-operator/templates/metrics-reader-rbac.yaml
- charts/s3-operator/templates/metrics-service.yaml
- charts/s3-operator/templates/proxy-rbac.yaml
- charts/s3-operator/templates/resourcequota-status-updater-binding-rbac.yaml
- charts/s3-operator/templates/resourcequota-status-updater-rbac.yaml
- charts/s3-operator/templates/s3bucket-crd.yaml
- charts/s3-operator/templates/s3user-crd.yaml
- charts/s3-operator/templates/s3userclaim-crd.yaml
- charts/s3-operator/templates/selfsigned-issuer.yaml
- charts/s3-operator/templates/serviceaccount.yaml
- charts/s3-operator/templates/serving-cert.yaml
- charts/s3-operator/templates/validating-webhook-configuration.yaml
- charts/s3-operator/templates/webhook-service.yaml
- charts/s3-operator/values.yaml
Files selected for processing (2)
- .github/release.yaml (1 hunks)
- .github/workflows/build-release.yaml (3 hunks)
Files skipped from review due to trivial changes (1)
- .github/release.yaml
Additional comments: 7
.github/workflows/build-release.yaml (7)
1-4: The workflow name change to "Build and Release" accurately reflects the expanded scope of the workflow.
3-4: The trigger condition for the workflow is correctly set to activate on tags that match 'v*', aligning with the PR objective to handle releases for new tags.
34-40: The "build-push-docker" job is correctly configured with steps for building and pushing the Docker image, including setting up QEMU, Buildx, Docker login, and metadata actions.
36-40: The "build-push-bundle" job correctly specifies a dependency on the "build-push-docker" job, ensuring that the Docker image is built before the bundle.
55-69: The "helm-chart" job is correctly added to handle Helm chart operations, including pushing the chart to an OCI registry, which aligns with the PR objective to manage Helm chart releases.
71-77: The "release" job is correctly added to automate the creation of GitHub releases and generate change logs, which aligns with the PR objective to introduce a release step triggered per tag.
66-66: > 💡 NOTE
Codebase verification is a beta feature.
The relocation of the Helm chart folder has been successfully verified with the presence of
charts/s3-operator/
in the repository. The path specified in the workflow file is correct.
This PR:
Summary by CodeRabbit
Chores
New Features