Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/GitHub workflows2 #26

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Improve/GitHub workflows2 #26

merged 4 commits into from
Dec 6, 2023

Conversation

hoptical
Copy link
Collaborator

@hoptical hoptical commented Dec 5, 2023

This PR:

  • moves helm chart folder from deploy/charts to charts
  • adds helm chart release step per tag
  • adds release step per tag with automated change log

Summary by CodeRabbit

  • Chores

    • Updated GitHub Actions workflow names for clarity.
  • New Features

    • Integrated Helm chart operations into the build process.
    • Automated the creation of GitHub releases as part of the CI/CD pipeline.

@hoptical hoptical requested a review from therealak12 December 5, 2023 15:16
@hoptical hoptical self-assigned this Dec 5, 2023
Copy link
Contributor

coderabbitai bot commented Dec 5, 2023

Walkthrough

The GitHub workflow has been updated to not only build container images but also manage Helm chart operations and create GitHub releases. This expansion streamlines the release process, integrating additional steps into the CI/CD pipeline.

Changes

File Path Change Summary
.github/release.yaml No functional changes; can be tagged as non-altering.
.github/workflows/build-release.yaml Renamed job, added "helm-chart" and "release" jobs for Helm and release management.

🐇✨
In the code's flow, a change does grow,
From build to release, the workflow's increase.
Helm charts in place, with a smooth, steady pace,
A rabbit's cheer for the release so near! 🚀🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b71aeb3 and a5becb6.
Files ignored due to filter (21)
  • charts/s3-operator/Chart.yaml
  • charts/s3-operator/templates/clusterresourcequota-updater-binding-rbac.yaml
  • charts/s3-operator/templates/clusterresourcequota-updater-rbac.yaml
  • charts/s3-operator/templates/controller-manager-config.yaml
  • charts/s3-operator/templates/deployment.yaml
  • charts/s3-operator/templates/leader-election-rbac.yaml
  • charts/s3-operator/templates/manager-rbac.yaml
  • charts/s3-operator/templates/metrics-reader-rbac.yaml
  • charts/s3-operator/templates/metrics-service.yaml
  • charts/s3-operator/templates/proxy-rbac.yaml
  • charts/s3-operator/templates/resourcequota-status-updater-binding-rbac.yaml
  • charts/s3-operator/templates/resourcequota-status-updater-rbac.yaml
  • charts/s3-operator/templates/s3bucket-crd.yaml
  • charts/s3-operator/templates/s3user-crd.yaml
  • charts/s3-operator/templates/s3userclaim-crd.yaml
  • charts/s3-operator/templates/selfsigned-issuer.yaml
  • charts/s3-operator/templates/serviceaccount.yaml
  • charts/s3-operator/templates/serving-cert.yaml
  • charts/s3-operator/templates/validating-webhook-configuration.yaml
  • charts/s3-operator/templates/webhook-service.yaml
  • charts/s3-operator/values.yaml
Files selected for processing (2)
  • .github/release.yaml (1 hunks)
  • .github/workflows/build-release.yaml (3 hunks)
Files skipped from review due to trivial changes (1)
  • .github/release.yaml
Additional comments: 7
.github/workflows/build-release.yaml (7)
  • 1-4: The workflow name change to "Build and Release" accurately reflects the expanded scope of the workflow.

  • 3-4: The trigger condition for the workflow is correctly set to activate on tags that match 'v*', aligning with the PR objective to handle releases for new tags.

  • 34-40: The "build-push-docker" job is correctly configured with steps for building and pushing the Docker image, including setting up QEMU, Buildx, Docker login, and metadata actions.

  • 36-40: The "build-push-bundle" job correctly specifies a dependency on the "build-push-docker" job, ensuring that the Docker image is built before the bundle.

  • 55-69: The "helm-chart" job is correctly added to handle Helm chart operations, including pushing the chart to an OCI registry, which aligns with the PR objective to manage Helm chart releases.

  • 71-77: The "release" job is correctly added to automate the creation of GitHub releases and generate change logs, which aligns with the PR objective to introduce a release step triggered per tag.

  • 66-66: > 💡 NOTE

Codebase verification is a beta feature.

The relocation of the Helm chart folder has been successfully verified with the presence of charts/s3-operator/ in the repository. The path specified in the workflow file is correct.

@hoptical hoptical added helm chart Helm chart is updated chore labels Dec 6, 2023
@hoptical hoptical merged commit afd015c into main Dec 6, 2023
3 checks passed
@hoptical hoptical deleted the improve/github-workflows2 branch December 6, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore helm chart Helm chart is updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants