-
Notifications
You must be signed in to change notification settings - Fork 0
J sre 2742 Convert to typescript #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you add a |
@whatisdot there is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this, and can confirm it works as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've re-run my tests and can confirm that this still works as expected.
This was partly a venture into using LLMs to generate a solution. While it is impressive, it's still lower quality than the work I've seen from @d10zero when she implements without AI assistance. This might be part of the "burgeoning churn" that this paper is referring to:
In 2022-2023, the rise of AI Assistants are strongly correlated with "mistake code"
being pushed to the repo. ...(the correlation between revisions needed and Copilot usage) have grown in tandem.
This probably means we need to be more critical of AI assistance/suggestions before we submit code for review.
What
Replaces the
cdktf-diff
SHELL logic within the action into typescript.Why
Logic is getting too complex to keep in shell. Logic in typescript will also allow us to write extensive test coverage.
How
Move logic into typescript and adds 100% tests coverage!