Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Conversation

@ChaituVR
Copy link
Contributor

No description provided.

@ChaituVR ChaituVR requested a review from wa0x6e July 31, 2024 15:35
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e
Copy link
Contributor

wa0x6e commented Jul 31, 2024

Didn't we have a JSON lint to prevent that ?

@ChaituVR
Copy link
Contributor Author

ChaituVR commented Jul 31, 2024

yea true, #2611 but somehow no action was ran on this PR 🤔

@ChaituVR ChaituVR merged commit 0e96486 into master Jul 31, 2024
@ChaituVR ChaituVR deleted the ChaituVR-patch-3 branch July 31, 2024 15:45
@wa0x6e
Copy link
Contributor

wa0x6e commented Jul 31, 2024

Seems like this action is not run when PR is opened by someone not from the team.

We could either:

  • Allow this action to always be run for PR opened by external contributor
  • Prevent the merge on master to continue when workflows are failing (I prefer this, and I think we're already using this on some repo)

@ChaituVR
Copy link
Contributor Author

Prevent the merge on master to continue when workflows are failing (I prefer this, and I think we're already using this on some repo)

For this @bonustrack need to change Branch protection rule settings similar to here https://github.com/snapshot-labs/snapshot.js/settings/branch_protection_rules/17997175
and add this action mandatory
Untitled 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants