-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flag proposal): add ability to flag proposal #679
Conversation
@@ -66,13 +66,15 @@ export default async function (parent, args) { | |||
params.push(verifiedSpaces); | |||
} | |||
|
|||
// TODO: remove part `p.id IN (?)` when flagged proposals are moved from laser DB to snapshot-sequencer DB | |||
if (where.flagged === true && flaggedProposals.length > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beware of the case where this condition will not be triggered if flaggedProposals.length
is 0.
Refactoring to remove p.id IN (?)
has to be done before disconnecting laser database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, thank you 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
src/helpers/schema.sql
Outdated
@@ -58,6 +59,7 @@ CREATE TABLE proposals ( | |||
INDEX scores_state (scores_state), | |||
INDEX scores_updated (scores_updated), | |||
INDEX votes (votes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing trailing comma here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 39 39
Lines 1878 1885 +7
Branches 39 39
======================================
- Misses 1839 1846 +7
Partials 39 39
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
Changes proposed in this pull request:
TODO:
Notes:
This PR doesn't remove the previous implementation and is backward compatible. The previous implementation will be removed when data is migrated from the laser DB to the new column. Probably it will be done in a separate PR