Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add space validation to prevent invalid settings #239

Merged
merged 15 commits into from
Nov 16, 2023

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Nov 10, 2023

Related to pitch https://github.com/orgs/snapshot-labs/projects/12/views/7?pane=issue&itemId=43161232

Add validation to prevent:

  • ticket strategy without validation
  • using testnet on snapshot.org, and mainnet on demo
  • don’t have proposal validation / authors only
  • Add tests

@wa0x6e wa0x6e changed the title fix: reject when the space do not exist fix: add space validation to prevent invalid settings Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b76f1a9) 44.58% compared to head (3b34878) 46.93%.

❗ Current head 3b34878 differs from pull request most recent head 9be288b. Consider uploading reports for the commit 9be288b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage   44.58%   46.93%   +2.34%     
==========================================
  Files          33       32       -1     
  Lines        2050     2086      +36     
  Branches      158      186      +28     
==========================================
+ Hits          914      979      +65     
+ Misses       1130     1102      -28     
+ Partials        6        5       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wa0x6e wa0x6e requested a review from ChaituVR November 13, 2023 10:51
@wa0x6e wa0x6e marked this pull request as ready for review November 13, 2023 10:51
src/writer/settings.ts Outdated Show resolved Hide resolved
@wa0x6e wa0x6e requested a review from ChaituVR November 15, 2023 16:35
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit 84c0261 into master Nov 16, 2023
@ChaituVR ChaituVR deleted the prevent-invalid-space-settings branch November 16, 2023 17:46
@samuveth
Copy link
Contributor

The UI is not ready for this yet, why was this merged? @ChaituVR

@samuveth
Copy link
Contributor

This is going to cause much confusion without the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants