-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add space validation to prevent invalid settings #239
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 44.58% 46.93% +2.34%
==========================================
Files 33 32 -1
Lines 2050 2086 +36
Branches 158 186 +28
==========================================
+ Hits 914 979 +65
+ Misses 1130 1102 -28
+ Partials 6 5 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
The UI is not ready for this yet, why was this merged? @ChaituVR |
This is going to cause much confusion without the UI |
Related to pitch https://github.com/orgs/snapshot-labs/projects/12/views/7?pane=issue&itemId=43161232
Add validation to prevent: