[subgraph-split-delegation] New strategy: Subgraph split delegation #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaituVR
requested changes
Sep 19, 2024
ChaituVR
reviewed
Sep 19, 2024
Comment on lines
129
to
160
| for (const chunk of chunks) { | ||
| const params = { | ||
| members: { | ||
| __args: { | ||
| block: { number: block.number }, | ||
| where: { | ||
| address_in: chunk.map((address) => address.toLowerCase()) | ||
| } | ||
| }, | ||
| id: true, | ||
| address: true, | ||
| delegators: { | ||
| __args: { | ||
| where: { | ||
| context: space, | ||
| expirationTimestamp_gte: block.timestamp | ||
| } | ||
| }, | ||
| delegator: { | ||
| address: true | ||
| }, | ||
| ratio: true | ||
| }, | ||
| delegatees: { | ||
| __args: { | ||
| where: { | ||
| context: space, | ||
| expirationTimestamp_gte: block.timestamp | ||
| } | ||
| }, | ||
| delegatee: { | ||
| address: true |
There was a problem hiding this comment.
But i think if a address has more than 1000 delegations this may ignore them?
There was a problem hiding this comment.
Yeah, I think you are right. I'm going to paginate the delegations too. Thanks!
ChaituVR
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subgraph-split-delegation calculates new Vp for the addresses based on the delegation ratios provided by a Subgraph endpoint and an initial strategy Vp.