Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add ts on views where missing #4395

Merged
merged 10 commits into from
Dec 7, 2023
Merged

chore: Add ts on views where missing #4395

merged 10 commits into from
Dec 7, 2023

Conversation

samuveth
Copy link
Contributor

@samuveth samuveth commented Nov 24, 2023

Summary

Use typescript in all view components

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
snapshot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 6:54am

@samuveth samuveth changed the title Fix ts delegate view chore: Fix ts delegate view Nov 24, 2023
@samuveth samuveth changed the title chore: Fix ts delegate view chore: Add ts on views where missing Nov 25, 2023
@samuveth samuveth marked this pull request as ready for review November 29, 2023 01:52
class="flex border-t px-4 py-3"
>
<BaseUser
:address="delegator.delegator"
:space="{ network: networkKey }"
Copy link
Collaborator

@wa0x6e wa0x6e Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why stop passing this space props ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, added it back

@wa0x6e wa0x6e self-requested a review November 29, 2023 12:39
Copy link
Collaborator

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@samuveth samuveth merged commit 3230a90 into master Dec 7, 2023
5 of 7 checks passed
@samuveth samuveth deleted the samuv/add-langts branch December 7, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants