Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add tooltip to vote button #4447

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix: Add tooltip to vote button #4447

merged 2 commits into from
Dec 13, 2023

Conversation

samuveth
Copy link
Contributor

@samuveth samuveth commented Dec 13, 2023

Summary

It might not be clear to the user that ranked choice voting requires all choices to be selected. To fix this I've added a tooltip to the disabled button.
Screenshot 2023-12-13 at 2 20 19 in the afternoon

Also added one for other voting types while at it
image

Also changes the disabled style of the primary button to fix the design on figma
image

@samuveth samuveth requested review from wa0x6e and ChaituVR December 13, 2023 07:24
Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
snapshot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 7:30am

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@samuveth samuveth merged commit d528351 into master Dec 13, 2023
3 checks passed
@samuveth samuveth deleted the fix-vote-tooltip branch December 13, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants