Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ask for symbol and decimals if covalent fail #4890

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Sep 28, 2024

Context https://discord.com/channels/955773041898573854/1030773050217615440/1289392373037662208

Summary

Form will now ask for symbol and decimals if covalent fail

How to test

  1. Go to space creation, strategies page, select "Token weighted voting"
  2. Select any network, Select any standard
  3. Enter an invalid token (for example your EOA address)
  4. It should ask for symbol and decimals if covalent fail, instead of showing the error
  5. You should be able to continue with space setup now

Before:
image

Now:
image

@bonustrack
Copy link
Member

We may want to remove Covalent too if thats just for the token image we can do the same with Stamp

@bonustrack bonustrack merged commit 75ea2b2 into master Sep 28, 2024
5 checks passed
@bonustrack bonustrack deleted the ask-for-symbol-and-decimals branch September 28, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants