Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable irrelevant custom domain and skin section #4960

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: disable irrelevant custom domain and skin section #4960

merged 1 commit into from
Jan 9, 2025

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Jan 8, 2025 •
edited
Loading

Summary

Toward https://github.com/snapshot-labs/workflow/issues/362

This PR will disable the custom domain and skin section in the space settings, since it's not relevant anymore:

  • the docs are outdated
  • custom domain does not work on v1
  • skin does not work on v1

How to test

  1. Go to a space settings, then advanced
  2. The section about custom domain and skin is gone

@wa0x6e wa0x6e mentioned this pull request Jan 8, 2025
Merged
@wa0x6e wa0x6e marked this pull request as ready for review January 8, 2025 20:39
@wa0x6e wa0x6e requested a review from ChaituVR January 8, 2025 20:40
bonustrack
bonustrack approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wa0x6e wa0x6e merged commit ca95067 into master Jan 9, 2025
7 checks passed
@wa0x6e wa0x6e deleted the fix-disable-custom-domain-and-skin branch January 9, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@ChaituVR ChaituVR Awaiting requested review from ChaituVR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @bonustrack