Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add whitelist strategy #100

Merged
merged 9 commits into from
May 4, 2022
Merged

Add whitelist strategy #100

merged 9 commits into from
May 4, 2022

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Apr 29, 2022 •
edited
Loading

  • Adds a simple whitelist strategy. The smart contract has no owner: whitelisted addresses are declared in the constructor. If we wish to add / remove addresses, just create a new smart contract (as this is a voting strategy and won't hold any funds, I think it's safe to to so).
  • As mentioned in Use of EthAddress in interfaces #99 , we will need to transition to something else than EthAddress as the type for the get_voting_power interface because we might also have starkkeys, or solana keys, or bitcoin keys etc...

Closes #92

@pscott pscott requested a review from Orland0x May 3, 2022 09:51
@pscott pscott merged commit 00b8365 into develop May 4, 2022
@Orland0x Orland0x deleted the add_whitelist_strategy branch September 12, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack left review comments

@Orland0x Orland0x Orland0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add whitelist strategy
3 participants
@pscott @bonustrack @Orland0x