Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min/max duration and quorum #111

Merged
merged 11 commits into from
May 12, 2022
Merged

Add min/max duration and quorum #111

merged 11 commits into from
May 12, 2022

Conversation

pscott
Copy link
Contributor

@pscott pscott commented May 8, 2022

Adds min and max voting duration:

  • min_voting_duration: a proposal can't be finalized before min_votin_duration has elapsed
  • max_voting_duration: a vote can't be cast after max_voting_duration has elapsed

I'd like to add more tests but currently we can't manipulate the block timestamp in starknet-devnet. We might want to add some later on though :)

Closes #95

@pscott pscott requested review from bonustrack and Orland0x May 8, 2022 13:08
@pscott pscott force-pushed the add_min_max_voting_period branch from 87bc3aa to 655ee06 Compare May 8, 2022 14:23
@Orland0x
Copy link
Contributor

I think we should implement quorum before adding this feature

@pscott
Copy link
Contributor Author

pscott commented May 10, 2022

I think we should implement quorum before adding this feature

0503bfb :) (missing tests, they will come in tomorrow hopefully :D)

@pscott pscott force-pushed the add_min_max_voting_period branch from 0503bfb to a2f2224 Compare May 11, 2022 08:16
@pscott pscott changed the title Add min max voting duration Add min/max duration and quorum May 11, 2022
@pscott
Copy link
Contributor Author

pscott commented May 11, 2022

Latest commits add the quorum storage var. It is stored on the space, and also stored on each new proposal so that if quorum changes during proposal, it doesn't disturb any of the ongoing proposals.

@pscott
Copy link
Contributor Author

pscott commented May 12, 2022

Also added a function to edit quorum as discussed on Discord (23e86a7) :D

@Orland0x Orland0x merged commit 07d2f9b into develop May 12, 2022
@Orland0x Orland0x deleted the add_min_max_voting_period branch September 12, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add minVotingPeriod and maxVotingPeriod parameters
3 participants