Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit storage vars #118

Merged
merged 7 commits into from
May 10, 2022
Merged

Edit storage vars #118

merged 7 commits into from
May 10, 2022

Conversation

pscott
Copy link
Contributor

@pscott pscott commented May 10, 2022 •
edited
Loading

This PR:

  • Allows the controller to edit all useful storage vars
  • Removes the need to use an array for voting_strategies by using it as a mapping and requiring the user / proposer to pass in used_voting_strategies which is a list of the user voting strategies (contract addresses) he wants to use
  • Adds events on storage vars edits AND on space creation

Closes #91

@pscott pscott requested a review from Orland0x May 10, 2022 14:25
@Orland0x Orland0x merged commit f49eeb5 into develop May 10, 2022
@pscott pscott mentioned this pull request May 11, 2022
Closed
@Orland0x Orland0x deleted the add_events_on_space branch September 12, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orland0x Orland0x Orland0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit an event when a space is created
2 participants
@pscott @Orland0x