Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #154

Merged
merged 65 commits into from
May 31, 2022
Merged

Refactor tests #154

merged 65 commits into from
May 31, 2022

Conversation

Orland0x
Copy link
Contributor

@Orland0x Orland0x commented May 27, 2022

General Housekeeping PR.

  • Refactored and standardised hardhat tests
  • Renamed files to follow OZ cairo conventions
  • Added contracts blueprint so increase ease of understanding the codebase
  • Updated to latest Starknet Hardhat and Devnet versions
  • Added Vanilla execution strategy for testing pruposes
  • Sped up tests by using lite mode setting on devnet in the GA

Orland0x and others added 21 commits May 26, 2022 15:20
* Bump ethers from 5.6.7 to 5.6.8 (#147)

Bumps [ethers](https://github.com/ethers-io/ethers.js/tree/HEAD/packages/ethers) from 5.6.7 to 5.6.8.
- [Release notes](https://github.com/ethers-io/ethers.js/releases)
- [Changelog](https://github.com/ethers-io/ethers.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ethers-io/ethers.js/commits/v5.6.8/packages/ethers)

---
updated-dependencies:
- dependency-name: ethers
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump typescript from 4.6.4 to 4.7.2 (#146)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.6.4 to 4.7.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.6.4...v4.7.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add starknet auth (#138)

* Update  to 0.8.1 and devnet 0.2.1; Format

* Add execute lib; Switch to authenticate method

* Add felt_to_uint256; Add starknet_tx auth

* Use felt instead of u256

* Add test for starknet tx auth

* Add starknet_tx_auth and starknet_account_auth; blocked by compilation on starknet_account_auth

* Remove starknet_account test; Rename starknet_account to starknet_sig

* Add comment about hash

* Update to 0.8.2

* Add voting_strategy_params_all to setup functions

* Bump npm from 8.10.0 to 8.11.0 (#149)

Bumps [npm](https://github.com/npm/cli) from 8.10.0 to 8.11.0.
- [Release notes](https://github.com/npm/cli/releases)
- [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md)
- [Commits](npm/cli@v8.10.0...v8.11.0)

---
updated-dependencies:
- dependency-name: npm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* renaming tests

* renamed cairo contracts

* fixed starknet tx auth test

* formatting

* updated starknet hardhat

* fixed account import

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pscott <30843220+pscott@users.noreply.github.com>
@Orland0x Orland0x requested a review from pscott May 30, 2022 10:49
Copy link
Contributor

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's gooooooo

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
contracts/ethereum/ZodiacModule/SnapshotXL1Executor.sol Outdated Show resolved Hide resolved
@Orland0x Orland0x merged commit fc0353a into develop May 31, 2022
@Orland0x Orland0x deleted the revamp_tests_2 branch July 25, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants