-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add merkle whitelist voting strategy #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add a bit more tests, and I think I'm missing why we need to sort the hashes :)
Also, is there an npm package that can take a hash_function
as a parameter to build a merkletree?:)
If you dont sort the hashes, then you need an additional positional argument for each hash in order to reconstruct the root. So it seems like standard practice to do so. Yeah there is a lib I tried to used called Agreed about the tests - will add more. I basically just copied this implementation, so wasn't too worried about correctness. https://github.com/ncitron/cairo-merkle-distributor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good ser!
utACK ;) (but CI will test for me :D)
closes #382