Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shahak/pytest with contract deployment test #41

Merged
merged 10 commits into from
Feb 28, 2022
Merged

Shahak/pytest with contract deployment test #41

merged 10 commits into from
Feb 28, 2022

Conversation

ShahakShama
Copy link
Contributor

No description provided.

@Orland0x
Copy link
Contributor

any reason this test was placed under the contracts/starknet rather than test/starknet?

@ShahakShama ShahakShama force-pushed the shahak/pytest_with_contract_deployment_test branch from bdd9379 to 6d86916 Compare February 27, 2022 15:07
@ShahakShama
Copy link
Contributor Author

We usually put the tests next to the source code. I see the rest of the tests in this repo are in the test/ dir so I changed this one to comply with the other tests

@Orland0x
Copy link
Contributor

We usually put the tests next to the source code. I see the rest of the tests in this repo are in the test/ dir so I changed this one to comply with the other tests

cool, just added the ethereum tests to an ethereum subdirectory

@ShahakShama
Copy link
Contributor Author

Looks good!

@Orland0x
Copy link
Contributor

Orland0x commented Feb 27, 2022 •
edited
Loading

I added a script to the package.json so one can now run all hardhat and python tests via yarn test

Orland0x
Orland0x approved these changes Feb 27, 2022
View reviewed changes
Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ShahakShama ShahakShama merged commit ec66726 into develop Feb 28, 2022
@ShahakShama ShahakShama deleted the shahak/pytest_with_contract_deployment_test branch February 28, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alon-dotan-starkware alon-dotan-starkware alon-dotan-starkware approved these changes

@Orland0x Orland0x Orland0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShahakShama @Orland0x @alon-dotan-starkware