Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vanilla Space Contract #47

Merged
merged 46 commits into from
Mar 7, 2022
Merged

Vanilla Space Contract #47

merged 46 commits into from
Mar 7, 2022

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Mar 1, 2022

As per what was described in milestone1, here is a vanilla space contract (missing correct types and tests).

@pscott pscott marked this pull request as draft March 1, 2022 17:11
@pscott pscott marked this pull request as ready for review March 6, 2022 09:35
@pscott
Copy link
Contributor Author

pscott commented Mar 7, 2022 •
edited
Loading

Decided to use a lib/ folder with a single file per new struct / type. 8371c1e

Can merge as soon as I get two approvals :)

@Orland0x
Copy link
Contributor

Orland0x commented Mar 7, 2022

looks good

@Orland0x Orland0x self-requested a review March 7, 2022 16:16
@Orland0x Orland0x requested a review from bonustrack March 7, 2022 16:20
bonustrack
bonustrack approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Orland0x Orland0x merged commit b6cbf14 into develop Mar 7, 2022
@Orland0x Orland0x deleted the vanilla_space branch May 4, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orland0x Orland0x Orland0x approved these changes

@bonustrack bonustrack bonustrack approved these changes

@ShahakShama ShahakShama Awaiting requested review from ShahakShama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pscott @Orland0x @bonustrack @ShahakShama