Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vanilla Voting Strategy #48

Merged
merged 12 commits into from
Mar 2, 2022
Merged

Vanilla Voting Strategy #48

merged 12 commits into from
Mar 2, 2022

Conversation

Orland0x
Copy link
Contributor

@Orland0x Orland0x commented Mar 1, 2022 •
edited
Loading

implementing a Vanilla voting strategy as described in milestone 1 (https://github.com/snapshot-labs/sx-core/blob/milestone-1/MILESTONE-1.md)

Additional updates:

  • Added a starknet devnet instance to the GA
  • typescript utlities for interacting with native cairo types (uint 256 and ints sequence)
  • Updated to latest version of the starknet hardhat plugin (4.2)
  • now using local cairo env for hardhat instead of docker container
  • snake_case for cairo contract names

Orland0x and others added 9 commits March 1, 2022 17:48
@Orland0x
vanilla voting strategy
edc6b6f
@Orland0x
formatting
f1c704f
@Orland0x
Update README.md
8039f53
@Orland0x
starknet devnet GA
94fdab3
@Orland0x
.Merge branch 'vanilla_vote' of https://github.com/snapshot-labs/sx-core
63ee43a 
 into vanilla_vote
@Orland0x
install cairo
81c0802
@Orland0x
GA ordering
5cf5f3a
@Orland0x
GA with starknet devnet instance (#49)
caaa4f4 
* Update tests.yml

* Update tests.yml

* Create github-actions-demo.yml

* Update tests.yml

* Delete github-actions-demo.yml

* Delete cairo_tests.yml

* Update lint.yml

* Update lint.yml

* Update lint.yml

* Update lint.yml

* Update lint.yml

* Update package.json
@Orland0x
Update lint.yml
d3820dc
@Orland0x Orland0x requested review from pscott and ShahakShama March 2, 2022 00:29
pscott
pscott approved these changes Mar 2, 2022
View reviewed changes
contracts/starknet/lib/types.cairo Outdated Show resolved Hide resolved
contracts/starknet/strategies/vanilla_voting_strategy.cairo Outdated Show resolved Hide resolved
hardhat.config.ts Show resolved Hide resolved
hardhat.config.ts Show resolved Hide resolved
test/starknet/shared/helpers.ts Show resolved Hide resolved
@Orland0x Orland0x merged commit 2cfb911 into develop Mar 2, 2022
@Orland0x Orland0x deleted the vanilla_vote branch March 2, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pscott pscott pscott approved these changes

@ShahakShama ShahakShama ShahakShama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Orland0x @pscott @ShahakShama