External authentification provider

[s18alg]

Hi everyone

I am trying to use an external api as the authentification provider to allow or deny websocket connection to my system.

I want to pass some of the websocket creation request from the client to the api, and my current code looks like:

    let auth_middleware_callback = |req: &Request, res: Response| {
        let task = client.on_connect(req.headers().get("Authorization");); // This is an async method wrapping around the hyper http client
        Ok(res)
    };
    let ws_stream = tokio_tungstenite::accept_hdr_async(raw_stream, auth_middleware_callback)

My issue is that I don't get how I can make the auth_middleware_callback an async closure (I get a compiler error saying they are not supported yet) and the lib give my some big type missmatch error if I try to feed it an async function.

I feel like I am missing something here, as the accept_hdr_async feels quite tailored for local authentification, but I don't see how to adapt it to my use case.

Thank you and have a nice day

[daniel-abramov]

Do you have a SSCCE? I may be wrong, but it might be related to #29

let task = client.on_connect(req.headers().get("Authorization");); // This is an async method wrapping around the hyper http client

But if it's an async method, then you would probably have to block at that point, waiting for it to complete (that may or may not be the desirable effect).

[s18alg]

On second read, it is indeed related to #29.
I also think it's the same need that inspired #51 (Which I almost implemented but don't like how verbose this solution is)

I ended up using a blocking http request to make my prototype run, but as the other issue pointed out, I kinda think tokio-tungstenite could use some future based authentification process that would suite me better.

I took a look at the code and I think I'll have time to contribute some code next week.

[daniel-abramov]

I kinda think tokio-tungstenite could use some future based authentification process that would suite me better.

That indeed would be very useful as it would allow to "inject" some middleware at this stage.

[s18alg]

So I finally found some time to dig this issue, and there is indeed some work needed on tungstenite itself to make it process an async callback.

[sammoh94]

Also running into this issue. Has there been any progress on this?

[s18alg]

From what I have been reading on other issue, no
From my investigation at the time, this is an issue related to tungstenite as the core lib reject async function