Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add some documentation to WebSocket and Error. #79

Merged
merged 2 commits into from
Sep 20, 2019

Conversation

najamelan
Copy link
Contributor

So as I have been figuring out from the source code how tungstenite works, I felt it would be silly to just let that disappear when my memory fades, so I wrote documentation, hoping it will also save others time.

This isn't polished:

I have no intention of polishing this, cause I have my own chores to do on my own libraries, but "Allow edits from maintainers" is on. Please use it.

Remove the statement which is not valid anymore.
Copy link
Member

@daniel-abramov daniel-abramov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@daniel-abramov daniel-abramov merged commit dd60245 into snapview:master Sep 20, 2019
@najamelan
Copy link
Contributor Author

@application-developer-DA Thanks for working through all of my feedback. I know it's long and I know I'm a nitpick, but I hope tungstenite is really a better library for it.
;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants