Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drain method to WebSocket{,Context} #95

Closed
wants to merge 1 commit into from

Conversation

jean-airoldie
Copy link

This allows the user to retrieve unsent queued messages
after a connection died.

Fixes #94

@daniel-abramov
Copy link
Member

Just a couple questions:

  1. Is it still a WIP (work in progress) PR or do you plan to extend it?
  2. Would it be possible to split the PR into multiple commits, so that the changes which only change the formatting of the code can be kept in a separate commit?

@jean-airoldie
Copy link
Author

jean-airoldie commented Nov 29, 2019

  1. Nah its not WIP anymore, forgot to rename the title.

  2. Sure thing, didn't realized that it picked up my rustfmt. I'll make a separate commit. I'll also add the travis logic to check for the formatting. Turns out that its not actually due to code formatting, but the git diff kinda messing up. I extract part of a function into another function and the indentation makes it seem like its a formatting thing.

@jean-airoldie jean-airoldie changed the title WIP: Add consume method to WebSocket{,Context} Add drain method to WebSocket{,Context} Nov 29, 2019
@jean-airoldie
Copy link
Author

Also I'm not sure whether agalakhov's comment #94 (comment) was addressed.

This allows the user to retrieve the content of the message
queue after the socket connection died.
@jean-airoldie
Copy link
Author

Closing in favor of #104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve queued message after close
2 participants