-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support manifest.json to install as WebApp #1757
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
{ | ||
"name": "brid.gy", | ||
"short_name": "brid.gy", | ||
"description": "📣 Connects your web site to social media. Likes, retweets, mentions, cross-posting, and more...", | ||
"id": "/", | ||
"start_url": "/", | ||
"scope": "/", | ||
"lang": "en", | ||
"dir": "ltr", | ||
"theme_color": "#428ef4", | ||
"background_color": "#ffffff", | ||
"display": "standalone", | ||
"orientation": "portrait-primary", | ||
"related_applications": [], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. probably remove these two? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not necessary There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not necessary, but I'd like to, since they're optional 😁 https://developer.mozilla.org/en-US/docs/Web/Manifest#members There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Misunderstanding here from my side :D. I meant: They are not necessary, because optional |
||
"prefer_related_applications": false, | ||
"icons": [ | ||
{ "src": "manifest-icons/icon-72x72.png", "sizes": "72x72", "type": "image/png" }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These aren't all necessary, right? I'd rather avoid maintaining lots of new logo files. Should we maybe just use some of the existing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Many different devices types needs different icons. These are the minimum for Chrome, Safari, Edge and so on. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Huh. Do those browsers not resize existing icons if there's not already a preferred size? Got a link with details? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's best practice many of these generators also use and low level for the main OS's Android and iOS. For one of my PWAs, I took the effort to look at all the specs and came up with over 80 icons, including the maskable stuff :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm. It sounds like the major browser and platforms generally scale down icons fine: GoogleChrome/lighthouse#291 (comment) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My experience is rather "should", but it is actually more of a marginal problem. Therefore, two or three slightly larger icons are also adequate There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great! There are currently six JPGs with opaque white background and five PNGs with transparent background, across a range of sizes and aspect ratios. Maybe we start with these, either some or all of them, and see how it goes?
|
||
{ "src": "manifest-icons/icon-96x96.png", "sizes": "96x96", "type": "image/png" }, | ||
{ "src": "manifest-icons/icon-128x128.png", "sizes": "128x128", "type": "image/png" }, | ||
{ "src": "manifest-icons/icon-144x144.png", "sizes": "144x144", "type": "image/png" }, | ||
{ "src": "manifest-icons/icon-152x152.png", "sizes": "152x152", "type": "image/png" }, | ||
{ "src": "manifest-icons/icon-192x192.png", "sizes": "192x192", "type": "image/png" }, | ||
{ "src": "manifest-icons/icon-384x384.png", "sizes": "384x384", "type": "image/png" }, | ||
{ "src": "manifest-icons/icon-512x512.png", "sizes": "512x512", "type": "image/png" } | ||
], | ||
"screenshots": [ | ||
{ | ||
"src": "manifest-screenshots/start-desktop.png", | ||
"sizes": "1200x850", | ||
"type": "image/png", | ||
"form_factor": "wide", | ||
"label": "Start Page" | ||
}, | ||
{ | ||
"src": "manifest-screenshots/which-desktop.png", | ||
"sizes": "1200x850", | ||
"type": "image/png", | ||
"form_factor": "wide", | ||
"label": "Choose Service Page" | ||
}, | ||
{ | ||
"src": "manifest-screenshots/mastodon-desktop.png", | ||
"sizes": "1200x850", | ||
"type": "image/png", | ||
"form_factor": "wide", | ||
"label": "Mastodon Page" | ||
}, | ||
{ | ||
"src": "manifest-screenshots/responses-desktop.png", | ||
"sizes": "1200x850", | ||
"type": "image/png", | ||
"form_factor": "wide", | ||
"label": "Responses Page" | ||
}, | ||
{ | ||
"src": "manifest-screenshots/start-mobile.png", | ||
"sizes": "410x800", | ||
"type": "image/png", | ||
"form_factor": "narrow", | ||
"label": "Start Page" | ||
}, | ||
{ | ||
"src": "manifest-screenshots/which-mobile.png", | ||
"sizes": "410x800", | ||
"type": "image/png", | ||
"form_factor": "narrow", | ||
"label": "Choose Service Page" | ||
}, | ||
{ | ||
"src": "manifest-screenshots/mastodon-mobile.png", | ||
"sizes": "410x800", | ||
"type": "image/png", | ||
"form_factor": "narrow", | ||
"label": "Mastodon Page" | ||
}, | ||
{ | ||
"src": "manifest-screenshots/responses-mobile.png", | ||
"sizes": "410x800", | ||
"type": "image/png", | ||
"form_factor": "narrow", | ||
"label": "Responses Page" | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bridgy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manifest needs a name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I meant to change it to
"Bridgy"
, not remove itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D