Enter busy state while destroying threads #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not work. once the thread is deregistered, if it has a pending signal, it's be suspended and never resumed. |
deadalnix
requested changes
Dec 4, 2024
|
No, because the signal could be pending, or could have been received and then the state is delayed. Since we know the thread is going away and about to be removed from the list, the right answer is to mark somehow that the thread should ignore the signal. I think I know how to do this -- enterBusyState, but never exit. Then the signal will be ignored, and it won't suspend. |
mThreadList lock, which is used in GC cycles.
schveiguy
force-pushed
the
fixdestroythread
branch
from
0c564b3 to
94d5fb8
Compare
|
That wasn't the expected solution, but i think it works. The obvious follow up question for me is whether we should start thread in busy state right away. That seems like the right thing to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mThreadList lock is taken while doing a whole host of things, such as scanning, or signaling.
If we don't enter the busy state, we could be paused while holding the lock to remove the thread, and this will deadlock the collection.