Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GC] Make sure we don't take a GC lock for grow/shrink calls without #414

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

schveiguy
Copy link
Contributor

entering a busy state.

@deadalnix
Copy link
Contributor

It's be preferable to create a proxy function for growLarge and shrinkLarge that marks things as busy, no?

@schveiguy
Copy link
Contributor Author

Yeah, I can do that instead.

Copy link
Contributor

@deadalnix deadalnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty much ok, but the emap parameter is at best redundant or at worse wrong. Just remove it.

sdlib/d/gc/tcache.d Outdated Show resolved Hide resolved
sdlib/d/gc/tcache.d Outdated Show resolved Hide resolved
@deadalnix deadalnix merged commit b0ca296 into snazzy-d:master Dec 23, 2024
5 checks passed
@schveiguy schveiguy deleted the addbusystates branch December 23, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants