Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctrine ODM service name is still wrong #318

Closed
usmanzafar opened this issue Jan 30, 2017 · 2 comments
Closed

Doctrine ODM service name is still wrong #318

usmanzafar opened this issue Jan 30, 2017 · 2 comments

Comments

@usmanzafar
Copy link

Hey guys as per the ticket #143 this should have been fixed but turns out the latest version still miss these definitions. I was going through the history of the file and seems like as per this commit everything in reference to ODM definition reverted back without talking about why these are being reverted.

I might be doing this wrong but can we revert that branch and merge it again, if not then i can send a quick PR if you guys cool with it ?

usmanzafar pushed a commit to usmanzafar/SncRedisBundle that referenced this issue Jan 30, 2017
@snc
Copy link
Owner

snc commented Jan 30, 2017

Hi, a PR would be welcome.

@usmanzafar
Copy link
Author

Aye aye captain, just sent a pr fingers crossed :). ps: I love this bundle this is my goto bundle for almost all projects. proud to be part of. cheers

snc added a commit that referenced this issue Jan 31, 2017
As per the ticket #318, reverting the odm definition change
@snc snc closed this as completed Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants