Make all bundle services private #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Symfony 3.4 recommended practice is to keep all services private and use declarative dependency injection. Closes #384
curry684
added
dx
sawmurai
approved these changes
Apr 9, 2018
|
Nope, good one, we'll have to fix that. |
|
I'd love to see how, I have a similar problem in my project. Reported #418. Thanks! |
|
Symfony offers the concept of a ServiceLocator where you can inject other services to be created lazily 😉 |
|
Great, waiting for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Symfony 3.4 recommended practice is to keep all services private
and use declarative dependency injection.
Closes #384