#419: Create a service locator for clients to be used in the commands. #433
Conversation
| @@ -1,6 +1,6 @@ | |||
| parameters: | |||
| env(REDIS_URL): redis://localhost | |||
| env(REDIS_PROFILE): 2.6 | |||
| env(REDIS_PROFILE): '2.6' | |||
There was a problem hiding this comment.
I think we should wait on a fix from Symfony for this : symfony/symfony#27470
It's a nice thing to automatically know when BC break are introduced.
There was a problem hiding this comment.
Removed it, since it wasn't directly related with the PR.
There was a problem hiding this comment.
Will add it again, as travis fails on PHP 7.1 and 7.2 when a float value is given!
There was a problem hiding this comment.
Can just keep it out, we're stalling new release until Symfony 4.1.1 is out anyway.
| } | ||
|
|
||
| /** | ||
| * @test |
There was a problem hiding this comment.
I am not sure this project is using this convention.
There was a problem hiding this comment.
I hope it's not a big deal. I find the test method names generally much more readable without the test... prefix. Same reason why I prefer the prophecy mocks over phpunit mocking.
There was a problem hiding this comment.
Sorry but preferring existing convention here, and all remaining tests use test prefixes.
remove unrelated .yaml change
made REDIS_PROFILE a string again, as travis fails on PHP 7.1 and 7.2
|
|
||
| $clientLocatorDefinition = $this->createClientLocatorDefinition($container, $clients); | ||
|
|
||
| $this->passClientLocatorToSncRedisCommans($container, $clientLocatorDefinition); |
|
@curry684 I renamed the test methods and fixed the typo. |
|
Thanks! |
I hope master is fine as target branch.