Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Predis] Fixes persistent connections when used many databases on the same instance #462

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

qRoC
Copy link
Contributor

@qRoC qRoC commented Oct 13, 2018

At the moment, the parameter value can only be boolean, so remote socket does not have a unique identifier. This is a potential error for those who use multiple databases on the same redis instance.

Reference on predis code

Old PR(for phpredis):
#276
#308

@curry684 curry684 added bug Not working as intended predis Specific to Predis labels Oct 15, 2018
Copy link
Collaborator

@curry684 curry684 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Travis fail is irrelevant.

Copy link
Collaborator

@B-Galati B-Galati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@curry684 curry684 merged commit 13dee35 into snc:2.1 Oct 15, 2018
@curry684
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not working as intended predis Specific to Predis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants