fix #498 - Add read_timeout connection option to phpredis #499
Conversation
|
@agus-k Could you let me know if it's ok for you please? |
|
I'm getting [RedisException]:Redis server went away on the setOption line for some reason. I'm using phpredis v3.1.6. What version are you using? |
|
Same version. Do you have the same behavior with |
|
|
|
@agus-k So when does this error occured in your workflow? Any stack trace? |
| ), | ||
| 'alias_test' | ||
| ); | ||
|
|
||
| $this->assertInstanceOf('\Snc\RedisBundle\Client\Phpredis\Client', $client); | ||
| $this->assertSame('toto', $client->getOption(\Redis::OPT_PREFIX)); | ||
| $this->assertSame(1, $client->getOption(\Redis::OPT_SERIALIZER)); | ||
| $this->assertSame(4., $client->getOption(\Redis::OPT_READ_TIMEOUT)); |
There was a problem hiding this comment.
To say it's a float and not an int. Without the dot, the test failed because it returns a float.
This option is a float in the doc of phpredis.
My bad, it was my mistake in a hurry. I double checked after pulling your commit. It works on my end. I'll close my PR. Thank you for the fix. |
|
@agus-k Nice, thanks for letting us know! |
fix #498