Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve settings ba1 to implement 1 #123

Merged
merged 2 commits into from
Aug 8, 2020
Merged

Conversation

pinterid
Copy link
Member

@pinterid pinterid commented Aug 7, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

  • Currently it is not possible to save changes user settings, if the E-Mail field is empty. Settings Save Bug #108

What is the new behavior (if this is a feature change)?

  • Now the E-Mail field is declared as required and the changes cannot be saved if its content is empty. Settings Save Bug #108

Other information:

  • Ref: 🐍

The Mail field is now a required field.
It is now not possible to save the changes if the Mail field is empty.
@pinterid pinterid added the bug Something isn't working label Aug 7, 2020
@pinterid pinterid self-assigned this Aug 7, 2020
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked if there are other empty fields causing
the save problem too?

@pinterid
Copy link
Member Author

pinterid commented Aug 7, 2020

Have you checked if there are other empty fields causing
the save problem too?

@schettn the mail field is the only required field (defined in the engine), although there was another bug on a user profile that if only the first name was entered and no last name, the name on a user profile was not displayed. But this issue was fixed in #122.

@pinterid pinterid requested a review from schettn August 7, 2020 09:55
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

Copy link
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schettn schettn added this to the SNEK Version 0.1.0 milestone Aug 7, 2020
@schettn schettn merged commit a211884 into implement-1 Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants