Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sponsorssection aa2 to master #131

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Add sponsorssection aa2 to master #131

merged 2 commits into from
Sep 8, 2020

Conversation

kleberbaum
Copy link
Member

The content of the sponsor text has been adjusted.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

  • Currently the content of the sponsor text is not fitting.

What is the new behavior (if this is a feature change)?

  • Now the content of the sponsor text is ok.

@kleberbaum
Update sponsor text
6b952cb 
The content of the sponsor text has been adjusted.
@kleberbaum kleberbaum added the enhancement New feature or request label Sep 8, 2020
@kleberbaum kleberbaum self-assigned this Sep 8, 2020
kleberbaum
kleberbaum commented Sep 8, 2020
View reviewed changes
Copy link
Member Author

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this text still needs some adjustment.

src/components/organisms/sections/Sponsors/index.jsx Outdated Show resolved Hide resolved
@schettn
Copy link
Member

schettn commented Sep 8, 2020

please merge add-sponsorssection-aa2 into implement-1

@kleberbaum kleberbaum changed the base branch from implement-2 to implement-1 September 8, 2020 13:22
@kleberbaum
Improve code quality
616984f 
The code quality was improved due to a request by @kleberbaum.
schettn
schettn approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

pinterid
pinterid approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinterid pinterid merged commit 8e5a7ee into implement-1 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinterid pinterid pinterid approved these changes

@schettn schettn schettn approved these changes

Assignees

@kleberbaum kleberbaum

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kleberbaum @schettn @pinterid