Add heart aa1 to implement 1 #49

pinterid · 2020-06-06T22:57:50Z

Checklist:

Have you added an explanation of what your changes do and why you'd like them to be included?
Have you updated or added documentation for the change?
Have you tested your changes with successful results?

Type of Changes:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation (non-breaking change which adds documentation)
Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

Currently there are no authentication methods. There should be authentication methods #45
Currently there are no registration methods. There should be registration methods #46
Currently there are no data handling methods. There should be data handling methods #47
Currently there is no fitting site title. There should be a fitting site title #48

What is the new behavior (if this is a feature change)?

Now there are authentication methods. There should be authentication methods #45
Now there are registration methods. There should be registration methods #46
Now there are data handling methods. There should be data handling methods #47
Now there is a fitting site title. There should be a fitting site title #48

Other information:

Ref: 🐍

A utility for themes has been added.

Implemented for export them for easy access from parent components.

Now the modals are imported directly from the models folder.

Added some utilities for base and variables.

The navbar and footer are displayed now.

Methods for authentications has been added.

js-sha256, obelisk.js, react-dropzone and tippy.js has been added.

A progress bar has been added.

The homepage is displayed now.

Now when pressing the login button in the navbar, it will be redirected to the root location.

Caching methods and data handling for intel data have been implemented.

Registration is now available. This includes a oAuth and gitlab connection.

The companypage is displayed now.

Starts the page on top when reloaded or redirected.

The profilepage is displayed now.

A settings modal has been added and implemented.

A invalid variable type has changed.

Now it is possible to upload and delete talks.

The site title has been changed to SNEK.

The talkspage is displayed now.

Now only the globalFunctions and globalState are passed as props.

Code quality has been improved

schettn

I left some suggestions

public/manifest.json

src/components/pages/TalkPage/index.jsx

src/App.js

pinterid

Some changes have to be made.

src/App.js

@pinterid

Suggestions from @pinterid and @schettn are applied now. Co-authored-by: Pinterics David <55298934+pinterid@users.noreply.github.com>

The mount condition has been refined and simplified.

schettn

LGTM

The code quality was improved due to request by Codacy.

The code quality was improved due to a request by Codacy.

kleberbaum

Should be ok to merge after a few changes.

public/index.html

src/components/molecules/modals/SettingsModal/settings.scss

@kleberbaum

The code quality was improved due to a request by @kleberbaum. Co-authored-by: Florian Kleber <kleberbaum@erebos.xyz>

@kleberbaum

The site title was changed due to a request by @kleberbaum. Co-authored-by: Florian Kleber <kleberbaum@erebos.xyz>

pinterid

Looks good to merge.

kleberbaum

Should be ok to merge.

schettn added 23 commits June 6, 2020 21:25

Add theme utility

3d12407

A utility for themes has been added.

Add modals index

00268f9

Implemented for export them for easy access from parent components.

Add forms index

da54118

Implemented for export them for easy access from parent components.

Update modal import

6d248b7

Now the modals are imported directly from the models folder.

Add utilities

80e4dbb

Added some utilities for base and variables.

Add Navbar and Footer to UI

28b4ef4

The navbar and footer are displayed now.

Add authentication

3b57b86

Methods for authentications has been added.

Add packages

ac7dc3f

js-sha256, obelisk.js, react-dropzone and tippy.js has been added.

Add MDB progress

7504457

A progress bar has been added.

Add HomePage to UI

da7a878

The homepage is displayed now.

Add Navbar login redirect

329f214

Now when pressing the login button in the navbar, it will be redirected to the root location.

Add caching and data handling

1b4a76b

Caching methods and data handling for intel data have been implemented.

Add Registration

746c78e

Registration is now available. This includes a oAuth and gitlab connection.

Add CompanyPage to UI

df7894a

The companypage is displayed now.

Add ScrollToTop

8cb9571

Starts the page on top when reloaded or redirected.

Add ProfilePage to UI

f4fa616

The profilepage is displayed now.

Add Settings

ea386d5

A settings modal has been added and implemented.

Update Calendar3D

2b4b962

A invalid variable type has changed.

Add talk upload and delete

d20372b

Now it is possible to upload and delete talks.

Change site title

4f6dd95

The site title has been changed to SNEK.

Add TalksPage to UI

8df2f04

The talkspage is displayed now.

Update prop passing

e7a6924

Now only the globalFunctions and globalState are passed as props.

Improve code quality

6d34e4b

Code quality has been improved

pinterid added the enhancement New feature or request label Jun 6, 2020

pinterid added this to the SNEK Version 0.1.0 milestone Jun 6, 2020

pinterid requested review from kleberbaum and schettn June 6, 2020 22:57

pinterid self-assigned this Jun 6, 2020

schettn requested changes Jun 6, 2020

View reviewed changes

public/manifest.json Outdated Show resolved Hide resolved

src/components/pages/TalkPage/index.jsx Outdated Show resolved Hide resolved

src/App.js Outdated Show resolved Hide resolved

pinterid commented Jun 6, 2020

View reviewed changes

schettn and others added 2 commits June 7, 2020 01:16

Apply suggestions from code review

c8b70e7

Suggestions from @pinterid and @schettn are applied now. Co-authored-by: Pinterics David <55298934+pinterid@users.noreply.github.com>

Update talks mount condition

05f091d

The mount condition has been refined and simplified.

schettn self-requested a review June 6, 2020 23:18

schettn approved these changes Jun 6, 2020

View reviewed changes

pinterid added 4 commits June 7, 2020 01:24

Improve code quality

d4ec7f9

The code quality was improved due to request by Codacy.

Merge remote-tracking branch 'origin/add-heart-aa1' into add-heart-aa1

c033884

Improve code quality

3bce1f2

The code quality was improved due to a request by Codacy.

Improve code quality

1c72e61

The code quality was improved due to a request by Codacy.

kleberbaum requested changes Jun 7, 2020

View reviewed changes

public/index.html Outdated Show resolved Hide resolved

src/components/molecules/modals/SettingsModal/settings.scss Outdated Show resolved Hide resolved

pinterid and others added 2 commits June 7, 2020 02:38

Improve code quality

26f6ec0

The code quality was improved due to a request by @kleberbaum. Co-authored-by: Florian Kleber <kleberbaum@erebos.xyz>

Update site title

b35995b

The site title was changed due to a request by @kleberbaum. Co-authored-by: Florian Kleber <kleberbaum@erebos.xyz>

pinterid requested a review from kleberbaum June 7, 2020 00:39

pinterid commented Jun 7, 2020

View reviewed changes

kleberbaum approved these changes Jun 7, 2020

View reviewed changes

schettn merged commit 1e5d8b5 into implement-1 Jun 7, 2020

pinterid mentioned this pull request Jun 7, 2020

Implement 1 to master #52

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add heart aa1 to implement 1 #49

Add heart aa1 to implement 1 #49

pinterid commented Jun 6, 2020

schettn left a comment

pinterid left a comment

schettn left a comment

kleberbaum left a comment

pinterid left a comment

kleberbaum left a comment

Add heart aa1 to implement 1 #49

Add heart aa1 to implement 1 #49

Conversation

pinterid commented Jun 6, 2020

schettn left a comment

Choose a reason for hiding this comment

pinterid left a comment

Choose a reason for hiding this comment

schettn left a comment

Choose a reason for hiding this comment

kleberbaum left a comment

Choose a reason for hiding this comment

pinterid left a comment

Choose a reason for hiding this comment

kleberbaum left a comment

Choose a reason for hiding this comment