Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add homepage aa1 to implement 1 #71

Merged
merged 4 commits into from
Jul 3, 2020
Merged

Add homepage aa1 to implement 1 #71

merged 4 commits into from
Jul 3, 2020

Conversation

Aichnerc
Copy link
Member

Two more sections have been added.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

@Aichnerc
Improve Landing Page
3de85cc 
Two more sections have been added.
@Aichnerc Aichnerc added the enhancement New feature or request label Jun 25, 2020
@Aichnerc Aichnerc added this to the SNEK Version 0.1.0 milestone Jun 25, 2020
@Aichnerc Aichnerc self-assigned this Jun 25, 2020
@Aichnerc
Improve code quality
f891a58 
Some issues have been fixed.
schettn
schettn approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pinterid
pinterid approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pinterid pinterid changed the title Improve Landing Page Add homepage aa1 to implement 1 Jun 26, 2020
schettn
schettn requested changes Jun 26, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my machine there is a issue with the date of the fancy week chart.
image
@Aichnerc have a look.

kleberbaum
kleberbaum approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

simonprast
simonprast approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@simonprast simonprast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks absolutely great

@schettn
Fix Invalid Date on LatestActivity Chart
390153a 
MomentJS cannot handle periods well, therefore I adjusted the dummy dates to
dashes.
@schettn schettn self-requested a review July 3, 2020 12:38
schettn
schettn approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schettn schettn merged commit 79ef8ba into implement-1 Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinterid pinterid pinterid approved these changes

@schettn schettn schettn approved these changes

@simonprast simonprast simonprast approved these changes

@kleberbaum kleberbaum kleberbaum approved these changes

Assignees

@Aichnerc Aichnerc

Labels
enhancement New feature or request
Projects
None yet
Milestone
SNEK Version 0.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Aichnerc @kleberbaum @simonprast @schettn @pinterid