Add a config option that can reduce lag #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a DisplaySync config setting and new internal logic around frame timing. Now you can play without vsync, or even adaptive sync, with lowered lag vs. vsync always on. There was a bug with vsync always on before that had to be fixed as part of closing #36, but I've gone ahead and tightened up frame timing completely, beyond just fixing that bug
Will this Pull Request break anything?
Hopefully not. I haven't tested support on Nintendo Switch, but I believe it should work; someone else can test. More changes might be needed for Windows/TCC support; if so, I can investigate and implement the needed changes, I have a Windows 10 setup
Suggested Testing Steps
Build and test on all supported platforms (Windows, Linux, macOS, Switch) using all possible values of the new DisplaySync config setting